From 1487a73f1697471d6cdd0a89340491faf19c506f Mon Sep 17 00:00:00 2001 From: Tyler Brock Date: Fri, 27 May 2016 19:04:49 -0700 Subject: [PATCH] Fix expected webhook external response format (#1934) --- spec/ParseHooks.spec.js | 2 +- src/Controllers/HooksController.js | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/spec/ParseHooks.spec.js b/spec/ParseHooks.spec.js index eba40b06..a9a3c71c 100644 --- a/spec/ParseHooks.spec.js +++ b/spec/ParseHooks.spec.js @@ -381,7 +381,7 @@ describe('Hooks', () => { object.hello = "world"; // Would need parse cloud express to set much more // But this should override the key upon return - res.json({success: {object: object}}); + res.json({success: object}); }); // The function is delete as the DB is dropped between calls Parse.Hooks.createTrigger("SomeRandomObject", "beforeSave" ,hookServerURL+"/BeforeSaveSome").then(function(){ diff --git a/src/Controllers/HooksController.js b/src/Controllers/HooksController.js index 636c9ada..90912c24 100644 --- a/src/Controllers/HooksController.js +++ b/src/Controllers/HooksController.js @@ -190,7 +190,7 @@ function wrapToHTTPRequest(hook, key) { request.post(hook.url, jsonRequest, function (err, httpResponse, body) { var result; if (body) { - if (typeof body == "string") { + if (typeof body === "string") { try { body = JSON.parse(body); } catch (e) { @@ -204,6 +204,8 @@ function wrapToHTTPRequest(hook, key) { } if (err) { return res.error(err); + } else if (hook.triggerName === 'beforeSave') { + return res.success({object: result}); } else { return res.success(result); }