refactor: replace hardcoded error codes with references (#7546)

This commit is contained in:
dblythy
2021-10-19 05:19:47 +11:00
committed by GitHub
parent b5fc0d59db
commit 12eb6c823b
13 changed files with 85 additions and 52 deletions

View File

@@ -91,7 +91,7 @@ export class AccountLockout {
err &&
err.code &&
err.message &&
err.code === 101 &&
err.code === Parse.Error.OBJECT_NOT_FOUND &&
err.message === 'Object not found.'
) {
return; // nothing to update so we are good

View File

@@ -197,7 +197,7 @@ class ParseLiveQueryServer {
} catch (error) {
Client.pushError(
client.parseWebSocket,
error.code || 141,
error.code || Parse.Error.SCRIPT_FAILED,
error.message || error,
false,
requestId
@@ -361,7 +361,7 @@ class ParseLiveQueryServer {
} catch (error) {
Client.pushError(
client.parseWebSocket,
error.code || 141,
error.code || Parse.Error.SCRIPT_FAILED,
error.message || error,
false,
requestId
@@ -682,7 +682,12 @@ class ParseLiveQueryServer {
client.pushConnect();
runLiveQueryEventHandlers(req);
} catch (error) {
Client.pushError(parseWebsocket, error.code || 141, error.message || error, false);
Client.pushError(
parseWebsocket,
error.code || Parse.Error.SCRIPT_FAILED,
error.message || error,
false
);
logger.error(
`Failed running beforeConnect for session ${request.sessionToken} with:\n Error: ` +
JSON.stringify(error)
@@ -822,7 +827,13 @@ class ParseLiveQueryServer {
installationId: client.installationId,
});
} catch (e) {
Client.pushError(parseWebsocket, e.code || 141, e.message || e, false, request.requestId);
Client.pushError(
parseWebsocket,
e.code || Parse.Error.SCRIPT_FAILED,
e.message || e,
false,
request.requestId
);
logger.error(
`Failed running beforeSubscribe on ${className} for session ${request.sessionToken} with:\n Error: ` +
JSON.stringify(e)