joe/kami-parse-server
Public Access
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix an issue in MongoTransform where transforming object type fields with null values fails (#2029)

Browse Source
This commit is contained in:
Dan Huang
2016-06-10 13:44:41 -07:00
committed by Drew
parent a00d795404
commit 11301d9590
3 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
spec/MongoTransform.spec.js
View File

@@ -16,6 +16,15 @@ describe('parseObjectToMongoObjectForCreate', () => {
done(); done();
}); });
it('an object with null values', (done) => {
var input = {objectWithNullValues: {isNull: null, notNull: 3}};
var output = transform.parseObjectToMongoObjectForCreate(null, input, {
fields: {objectWithNullValues: {type: 'object'}}
});
jequal(input, output);
done();
});
it('built-in timestamps', (done) => { it('built-in timestamps', (done) => {
var input = { var input = {
createdAt: "2015-10-06T21:24:50.332Z", createdAt: "2015-10-06T21:24:50.332Z",

2
spec/helper.js
View File

@@ -209,7 +209,7 @@ function arrayContains(arr, item) {
// Normalizes a JSON object. // Normalizes a JSON object.
function normalize(obj) { function normalize(obj) {
if (typeof obj !== 'object') { if (obj === null || typeof obj !== 'object') {
return JSON.stringify(obj); return JSON.stringify(obj);
} }
if (obj instanceof Array) { if (obj instanceof Array) {

2
src/Adapters/Storage/Mongo/MongoTransform.js
View File

@@ -83,7 +83,7 @@ const transformKeyValueForUpdate = (className, restKey, restValue, parseFormatSc
} }
const transformInteriorValue = restValue => { const transformInteriorValue = restValue => {
if (typeof restValue === 'object' && Object.keys(restValue).some(key => key.includes('$') || key.includes('.'))) { if (restValue !== null && typeof restValue === 'object' && Object.keys(restValue).some(key => key.includes('$') || key.includes('.'))) {
throw new Parse.Error(Parse.Error.INVALID_NESTED_KEY, "Nested keys should not contain the '$' or '.' characters"); throw new Parse.Error(Parse.Error.INVALID_NESTED_KEY, "Nested keys should not contain the '$' or '.' characters");
} }
// Handle atomic values // Handle atomic values