joe/kami-parse-server
Public Access
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: consistent casing for afterLiveQueryEvent (#7023)

Browse Source
This commit is contained in:
dblythy
2020-11-25 08:58:35 +11:00
committed by GitHub
parent d4f405d972
commit 0bf2e84f81
2 changed files with 17 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
spec/ParseLiveQuery.spec.js
View File

@@ -38,7 +38,7 @@ describe('ParseLiveQuery', function () {
silent: true, silent: true,
}); });
Parse.Cloud.afterLiveQueryEvent('TestObject', req => { Parse.Cloud.afterLiveQueryEvent('TestObject', req => {
expect(req.event).toBe('Create'); expect(req.event).toBe('create');
expect(req.user).toBeUndefined(); expect(req.user).toBeUndefined();
expect(req.object.get('foo')).toBe('bar'); expect(req.object.get('foo')).toBe('bar');
}); });
@@ -68,7 +68,7 @@ describe('ParseLiveQuery', function () {
await object.save(); await object.save();
Parse.Cloud.afterLiveQueryEvent('TestObject', req => { Parse.Cloud.afterLiveQueryEvent('TestObject', req => {
expect(req.event).toBe('Update'); expect(req.event).toBe('update');
expect(req.user).toBeUndefined(); expect(req.user).toBeUndefined();
expect(req.object.get('foo')).toBe('bar'); expect(req.object.get('foo')).toBe('bar');
expect(req.original.get('foo')).toBeUndefined(); expect(req.original.get('foo')).toBeUndefined();
@@ -92,7 +92,7 @@ describe('ParseLiveQuery', function () {
silent: true, silent: true,
}); });
Parse.Cloud.afterLiveQueryEvent('TestObject', req => { Parse.Cloud.afterLiveQueryEvent('TestObject', req => {
expect(req.event).toBe('Enter'); expect(req.event).toBe('enter');
expect(req.user).toBeUndefined(); expect(req.user).toBeUndefined();
expect(req.object.get('foo')).toBe('bar'); expect(req.object.get('foo')).toBe('bar');
expect(req.original.get('foo')).toBeUndefined(); expect(req.original.get('foo')).toBeUndefined();
@@ -123,7 +123,7 @@ describe('ParseLiveQuery', function () {
silent: true, silent: true,
}); });
Parse.Cloud.afterLiveQueryEvent('TestObject', req => { Parse.Cloud.afterLiveQueryEvent('TestObject', req => {
expect(req.event).toBe('Leave'); expect(req.event).toBe('leave');
expect(req.user).toBeUndefined(); expect(req.user).toBeUndefined();
expect(req.object.get('foo')).toBeUndefined(); expect(req.object.get('foo')).toBeUndefined();
expect(req.original.get('foo')).toBe('bar'); expect(req.original.get('foo')).toBe('bar');
@@ -155,7 +155,7 @@ describe('ParseLiveQuery', function () {
silent: true, silent: true,
}); });
Parse.Cloud.afterLiveQueryEvent('TestObject', req => { Parse.Cloud.afterLiveQueryEvent('TestObject', req => {
expect(req.event).toBe('Delete'); expect(req.event).toBe('delete');
expect(req.user).toBeUndefined(); expect(req.user).toBeUndefined();
req.object.set('foo', 'bar'); req.object.set('foo', 'bar');
}); });
@@ -315,7 +315,7 @@ describe('ParseLiveQuery', function () {
silent: true, silent: true,
}); });
Parse.Cloud.afterLiveQueryEvent('TestObject', req => { Parse.Cloud.afterLiveQueryEvent('TestObject', req => {
expect(req.event).toBe('Create'); expect(req.event).toBe('create');
expect(req.user).toBeUndefined(); expect(req.user).toBeUndefined();
expect(req.object.get('foo')).toBe('bar'); expect(req.object.get('foo')).toBe('bar');
}); });
@@ -345,7 +345,7 @@ describe('ParseLiveQuery', function () {
await object.save(); await object.save();
Parse.Cloud.afterLiveQueryEvent('TestObject', req => { Parse.Cloud.afterLiveQueryEvent('TestObject', req => {
expect(req.event).toBe('Update'); expect(req.event).toBe('update');
expect(req.user).toBeUndefined(); expect(req.user).toBeUndefined();
expect(req.object.get('foo')).toBe('bar'); expect(req.object.get('foo')).toBe('bar');
expect(req.original.get('foo')).toBeUndefined(); expect(req.original.get('foo')).toBeUndefined();
@@ -369,7 +369,7 @@ describe('ParseLiveQuery', function () {
silent: true, silent: true,
}); });
Parse.Cloud.afterLiveQueryEvent('TestObject', req => { Parse.Cloud.afterLiveQueryEvent('TestObject', req => {
expect(req.event).toBe('Enter'); expect(req.event).toBe('enter');
expect(req.user).toBeUndefined(); expect(req.user).toBeUndefined();
expect(req.object.get('foo')).toBe('bar'); expect(req.object.get('foo')).toBe('bar');
expect(req.original.get('foo')).toBeUndefined(); expect(req.original.get('foo')).toBeUndefined();
@@ -400,7 +400,7 @@ describe('ParseLiveQuery', function () {
silent: true, silent: true,
}); });
Parse.Cloud.afterLiveQueryEvent('TestObject', req => { Parse.Cloud.afterLiveQueryEvent('TestObject', req => {
expect(req.event).toBe('Leave'); expect(req.event).toBe('leave');
expect(req.user).toBeUndefined(); expect(req.user).toBeUndefined();
expect(req.object.get('foo')).toBeUndefined(); expect(req.object.get('foo')).toBeUndefined();
expect(req.original.get('foo')).toBe('bar'); expect(req.original.get('foo')).toBe('bar');
@@ -432,7 +432,7 @@ describe('ParseLiveQuery', function () {
silent: true, silent: true,
}); });
Parse.Cloud.afterLiveQueryEvent('TestObject', req => { Parse.Cloud.afterLiveQueryEvent('TestObject', req => {
expect(req.event).toBe('Delete'); expect(req.event).toBe('delete');
expect(req.user).toBeUndefined(); expect(req.user).toBeUndefined();
req.object.set('foo', 'bar'); req.object.set('foo', 'bar');
}); });

13
src/LiveQuery/ParseLiveQueryServer.js
View File

@@ -160,7 +160,7 @@ class ParseLiveQueryServer {
return null; return null;
} }
res = { res = {
event: 'Delete', event: 'delete',
sessionToken: client.sessionToken, sessionToken: client.sessionToken,
object: deletedParseObject, object: deletedParseObject,
clients: this.clients.size, clients: this.clients.size,
@@ -275,14 +275,14 @@ class ParseLiveQueryServer {
// Decide event type // Decide event type
let type; let type;
if (isOriginalMatched && isCurrentMatched) { if (isOriginalMatched && isCurrentMatched) {
type = 'Update'; type = 'update';
} else if (isOriginalMatched && !isCurrentMatched) { } else if (isOriginalMatched && !isCurrentMatched) {
type = 'Leave'; type = 'leave';
} else if (!isOriginalMatched && isCurrentMatched) { } else if (!isOriginalMatched && isCurrentMatched) {
if (originalParseObject) { if (originalParseObject) {
type = 'Enter'; type = 'enter';
} else { } else {
type = 'Create'; type = 'create';
} }
} else { } else {
return null; return null;
@@ -315,7 +315,8 @@ class ParseLiveQueryServer {
originalParseObject = res.original.toJSON(); originalParseObject = res.original.toJSON();
originalParseObject.className = res.original.className || className; originalParseObject.className = res.original.className || className;
} }
const functionName = 'push' + message.event; const functionName =
'push' + message.event.charAt(0).toUpperCase() + message.event.slice(1);
if (client[functionName]) { if (client[functionName]) {
client[functionName](requestId, currentParseObject, originalParseObject); client[functionName](requestId, currentParseObject, originalParseObject);
} }