Fix for #1840, Strip operations from results, forwards delete operations to SDKs (#1946)

* Adding a test demonstrating issue #1840.

* Fixes #1840

* Adds failing test with other use case

- That test fails on parse.com as well

* Bumps parse to 1.9.0

* exclude pg db

* Exclude pg on other test

* Adds clientSDK compatibility check for forward deletion

- Mark js1.9.0 as compatible

* Strips all operations from result

- fix for #1606

spec/ClientSDK.spec.js

@@ -0,0 +1,41 @@
+var ClientSDK = require('../src/ClientSDK');
+
+describe('ClientSDK', () => {
+  it('should properly parse the SDK versions', () => {
+      let clientSDKFromVersion = ClientSDK.fromString;
+      expect(clientSDKFromVersion('i1.1.1')).toEqual({
+          sdk: 'i',
+          version: '1.1.1'
+      });
+      expect(clientSDKFromVersion('i1')).toEqual({
+          sdk: 'i',
+          version: '1'
+      });
+      expect(clientSDKFromVersion('apple-tv1.13.0')).toEqual({
+          sdk: 'apple-tv',
+          version: '1.13.0'
+      });
+      expect(clientSDKFromVersion('js1.9.0')).toEqual({
+          sdk: 'js',
+          version: '1.9.0'
+      });
+  });
+  
+  it('should properly sastisfy', () => {
+    expect(ClientSDK.compatible({
+      js: '>=1.9.0'
+    })("js1.9.0")).toBe(true);
+    
+    expect(ClientSDK.compatible({
+      js: '>=1.9.0'
+    })("js2.0.0")).toBe(true);
+
+    expect(ClientSDK.compatible({
+      js: '>=1.9.0'
+    })("js1.8.0")).toBe(false);
+
+    expect(ClientSDK.compatible({
+      js: '>=1.9.0'
+    })(undefined)).toBe(true);
+  })
+})

spec/CloudCode.spec.js

@@ -666,4 +666,114 @@ describe('Cloud Code', () => {
       done();
     });
   });
+
+  it_exclude_dbs(['postgres'])('should fully delete objects when using `unset` with beforeSave (regression test for #1840)', done => {
+    var TestObject = Parse.Object.extend('TestObject');
+    var NoBeforeSaveObject = Parse.Object.extend('NoBeforeSave');
+    var BeforeSaveObject = Parse.Object.extend('BeforeSaveChanged');
+
+    Parse.Cloud.beforeSave('BeforeSaveChanged', (req, res) => {
+      var object = req.object;
+      object.set('before', 'save');
+      res.success();
+    });
+
+    Parse.Cloud.define('removeme', (req, res) => {
+      var testObject = new TestObject();
+      testObject.save()
+      .then(testObject => {
+        var object = new NoBeforeSaveObject({remove: testObject});
+        return object.save();
+      })
+      .then(object => {
+        object.unset('remove');
+        return object.save();
+      })
+      .then(object => {
+        res.success(object);
+      });
+    });
+
+    Parse.Cloud.define('removeme2', (req, res) => {
+      var testObject = new TestObject();
+      testObject.save()
+      .then(testObject => {
+        var object = new BeforeSaveObject({remove: testObject});
+        return object.save();
+      })
+      .then(object => {
+        object.unset('remove');
+        return object.save();
+      })
+      .then(object => {
+        res.success(object);
+      });
+    });
+
+    Parse.Cloud.run('removeme')
+    .then(aNoBeforeSaveObj => {
+      expect(aNoBeforeSaveObj.get('remove')).toEqual(undefined);
+
+      return Parse.Cloud.run('removeme2');
+    })
+    .then(aBeforeSaveObj => {
+      expect(aBeforeSaveObj.get('before')).toEqual('save');
+      expect(aBeforeSaveObj.get('remove')).toEqual(undefined);
+      done();
+    });
+  });
+
+  it_exclude_dbs(['postgres'])('should fully delete objects when using `unset` with beforeSave (regression test for #1840)', done => {
+    var TestObject = Parse.Object.extend('TestObject');
+    var BeforeSaveObject = Parse.Object.extend('BeforeSaveChanged');
+
+    Parse.Cloud.beforeSave('BeforeSaveChanged', (req, res) => {
+      var object = req.object;
+      object.set('before', 'save');
+      object.unset('remove');
+      res.success();
+    });
+
+    let object;
+    let testObject = new TestObject({key: 'value'});
+    testObject.save().then(() => {
+       object = new BeforeSaveObject();
+       return object.save().then(() => {
+          object.set({remove:testObject})
+          return object.save();
+       });
+    }).then((objectAgain) => {
+       expect(objectAgain.get('remove')).toBeUndefined();
+       expect(object.get('remove')).toBeUndefined();
+       done();
+    }).fail((err) => {
+      console.error(err);
+      done();
+    })
+  });
+
+  it_exclude_dbs(['postgres'])('should not include relation op (regression test for #1606)', done => {
+    var TestObject = Parse.Object.extend('TestObject');
+    var BeforeSaveObject = Parse.Object.extend('BeforeSaveChanged');
+    let testObj;
+    Parse.Cloud.beforeSave('BeforeSaveChanged', (req, res) => {
+      var object = req.object;
+      object.set('before', 'save');
+      testObj = new TestObject();
+      testObj.save().then(() => {
+        object.relation('testsRelation').add(testObj);
+        res.success();
+      })
+    });
+
+    let object = new BeforeSaveObject();
+    object.save().then((objectAgain) => {
+      // Originally it would throw as it would be a non-relation
+      expect(() => { objectAgain.relation('testsRelation') }).not.toThrow();
+      done();
+    }).fail((err) => {
+      console.error(err);
+      done();
+    })
+  });
 });

spec/Middlewares.spec.js

@@ -66,24 +66,4 @@ describe('middlewares', () => {
             });
         });
     });
-
-    it('should properly parse the SDK versions', () => {
-        let clientSDKFromVersion = middlewares.clientSDKFromVersion;
-        expect(clientSDKFromVersion('i1.1.1')).toEqual({
-            sdk: 'i',
-            version: '1.1.1'
-        });
-        expect(clientSDKFromVersion('i1')).toEqual({
-            sdk: 'i',
-            version: '1'
-        });
-        expect(clientSDKFromVersion('apple-tv1.13.0')).toEqual({
-            sdk: 'apple-tv',
-            version: '1.13.0'
-        });
-        expect(clientSDKFromVersion('js1.9.0')).toEqual({
-            sdk: 'js',
-            version: '1.9.0'
-        });
-    })
 });