From 05f5aa0eb326a7fca8a7c66d1f51e1fbd271a635 Mon Sep 17 00:00:00 2001 From: Antoine Cormouls Date: Mon, 21 Dec 2020 18:14:07 +0100 Subject: [PATCH] Fix max listener warning from livequery server (#7083) * fix max listner warning * fix * Clean test log --- spec/EnableExpressErrorHandler.spec.js | 1 + src/Adapters/PubSub/EventEmitterPubSub.js | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/spec/EnableExpressErrorHandler.spec.js b/spec/EnableExpressErrorHandler.spec.js index fa73d21f..26483ec6 100644 --- a/spec/EnableExpressErrorHandler.spec.js +++ b/spec/EnableExpressErrorHandler.spec.js @@ -2,6 +2,7 @@ const request = require('../lib/request'); describe('Enable express error handler', () => { it('should call the default handler in case of error, like updating a non existing object', async done => { + spyOn(console, 'error'); const parseServer = await reconfigureServer( Object.assign({}, defaultConfiguration, { enableExpressErrorHandler: true, diff --git a/src/Adapters/PubSub/EventEmitterPubSub.js b/src/Adapters/PubSub/EventEmitterPubSub.js index 1ecc006e..277118a0 100644 --- a/src/Adapters/PubSub/EventEmitterPubSub.js +++ b/src/Adapters/PubSub/EventEmitterPubSub.js @@ -46,6 +46,10 @@ function createPublisher(): any { } function createSubscriber(): any { + // createSubscriber is called once at live query server start + // to avoid max listeners warning, we should clean up the event emitter + // each time this function is called + emitter.removeAllListeners(); return new Subscriber(emitter); }