Remove request and request-promise from dev dependencies (#5077)

* removes from emailverificationtoken spec

* updates winston

* Updates ValidationAndPasswordsReset

* Use local request in schemas

* Removes request in rest.spec

* Removes request from PushRouter0

* removes request from public API

* removes request from index.spec

* Removes request form parse.push spec

* removes request from ParseInstallation spec

* Removes from ParseHooks

* removes request from ParseGlobalConfig.spec

* Removes request from ParseAPI.spec.js

* removes request from LogsRouter

* removes in features

* Filters undefined headers instead of crashing

* Removes request from ParseUser spec

* Removes usage of request in ParseFile.spec.js

* Removes request from AuthAdapters.js

* removes request-promise from ParseGeoPoint.spec

* Removes request-promise from ParseQuery spec

* remove request-promise from UserPII

* removes request-promise from EnableExpressErrorHandler

* Updates RevocableSessionUpgrade spec

* Update RestQuery

* Removes read preferenceOptionM

* ensure we forward auth from URL

* use request in CloudCode.spec.js

* Removes request-promise from JobSchedule.spec

* Removes rp from VerifyUserPassword.spec.js

* Removes rp from PasswordPolicy spec

* Removes rp from ParsePolygon spec

* Removes rp from fullTextSearch spec

* Removes rp from PArseQuery.Aggregate

* Ensure we properly forward errors

* Removes request and request-promise

spec/PublicAPI.spec.js

@@ -1,11 +1,17 @@
-const request = require('request');
+const req = require('../lib/request');
+
+const request = function(url, callback) {
+  return req({
+    url,
+  }).then(response => callback(null, response), err => callback(err, err));
+};
 
 describe('public API', () => {
   it('should get invalid_link.html', done => {
     request(
       'http://localhost:8378/1/apps/invalid_link.html',
       (err, httpResponse) => {
-        expect(httpResponse.statusCode).toBe(200);
+        expect(httpResponse.status).toBe(200);
         done();
       }
     );
@@ -19,7 +25,7 @@ describe('public API', () => {
       request(
         'http://localhost:8378/1/apps/choose_password?id=test',
         (err, httpResponse) => {
-          expect(httpResponse.statusCode).toBe(200);
+          expect(httpResponse.status).toBe(200);
           done();
         }
       );
@@ -30,7 +36,7 @@ describe('public API', () => {
     request(
       'http://localhost:8378/1/apps/verify_email_success.html',
       (err, httpResponse) => {
-        expect(httpResponse.statusCode).toBe(200);
+        expect(httpResponse.status).toBe(200);
         done();
       }
     );
@@ -40,7 +46,7 @@ describe('public API', () => {
     request(
       'http://localhost:8378/1/apps/password_reset_success.html',
       (err, httpResponse) => {
-        expect(httpResponse.statusCode).toBe(200);
+        expect(httpResponse.status).toBe(200);
         done();
       }
     );
@@ -55,7 +61,7 @@ describe('public API without publicServerURL', () => {
     request(
       'http://localhost:8378/1/apps/test/verify_email',
       (err, httpResponse) => {
-        expect(httpResponse.statusCode).toBe(404);
+        expect(httpResponse.status).toBe(404);
         done();
       }
     );
@@ -65,7 +71,7 @@ describe('public API without publicServerURL', () => {
     request(
       'http://localhost:8378/1/apps/choose_password?id=test',
       (err, httpResponse) => {
-        expect(httpResponse.statusCode).toBe(404);
+        expect(httpResponse.status).toBe(404);
         done();
       }
     );
@@ -75,7 +81,7 @@ describe('public API without publicServerURL', () => {
     request(
       'http://localhost:8378/1/apps/test/request_password_reset',
       (err, httpResponse) => {
-        expect(httpResponse.statusCode).toBe(404);
+        expect(httpResponse.status).toBe(404);
         done();
       }
     );
@@ -91,7 +97,7 @@ describe('public API supplied with invalid application id', () => {
     request(
       'http://localhost:8378/1/apps/invalid/verify_email',
       (err, httpResponse) => {
-        expect(httpResponse.statusCode).toBe(403);
+        expect(httpResponse.status).toBe(403);
         done();
       }
     );
@@ -101,7 +107,7 @@ describe('public API supplied with invalid application id', () => {
     request(
       'http://localhost:8378/1/apps/choose_password?id=invalid',
       (err, httpResponse) => {
-        expect(httpResponse.statusCode).toBe(403);
+        expect(httpResponse.status).toBe(403);
         done();
       }
     );
@@ -111,27 +117,27 @@ describe('public API supplied with invalid application id', () => {
     request(
       'http://localhost:8378/1/apps/invalid/request_password_reset',
       (err, httpResponse) => {
-        expect(httpResponse.statusCode).toBe(403);
+        expect(httpResponse.status).toBe(403);
         done();
       }
     );
   });
 
   it('should get 403 on post of request_password_reset', done => {
-    request.post(
-      'http://localhost:8378/1/apps/invalid/request_password_reset',
-      (err, httpResponse) => {
-        expect(httpResponse.statusCode).toBe(403);
-        done();
-      }
-    );
+    req({
+      url: 'http://localhost:8378/1/apps/invalid/request_password_reset',
+      method: 'POST',
+    }).then(done.fail, httpResponse => {
+      expect(httpResponse.status).toBe(403);
+      done();
+    });
   });
 
   it('should get 403 on resendVerificationEmail', done => {
     request(
       'http://localhost:8378/1/apps/invalid/resend_verification_email',
       (err, httpResponse) => {
-        expect(httpResponse.statusCode).toBe(403);
+        expect(httpResponse.status).toBe(403);
         done();
       }
     );