joe/kami-parse-server
Public Access
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

added an RFC 7662 compliant OAuth2 auth adapter (#4910)

Browse Source 
* added an RFC 7662 compliant OAuth2 auth adapter

* forgot to add the actual auth adapter to the previous commit

* fixed lint errors

* * added test coverage
* changed option names in auth adapter from snake case to camel case
* added underscore prefix to helper function names
* merged consecutive logger calls into one call and use JSON.stringify() to convert JSON objects to strings
* changed error handling (ParseErrors are no longer thrown, but returned)

* added description of the "debug" option and added this option to the tests too

* added a check of the "debug" option to the unittests and replaced require() of the logger with an import (the former does not work correctly)

* added AuthAdapter based auth adapter runtime validation to src/Adapters/Auth/index.js, added capability to define arbitrary providernames with an "adapter" property in auth config, replaced various "var" keywords with "const" in oauth2.js

* incorporated changes requested by flovilmart (mainly that oauth2 is now not a standalone adapter, but can be selected by setting the "oauth2" property to true in auth config

* modified oauth2 adapter as requested by flovilmart

* bugfix: defaultAdapter can be null in loadAuthAdapter() of index.js (my change broke the tests)

* added TODO on need for a validateAdapter() to validate auth adapters

* test cases and cleanup
This commit is contained in:
Müller Zsolt
2019-04-11 18:05:55 +02:00
committed by Diamond Lewis
parent a3746cab00
commit 019cf0a986
4 changed files with 608 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/Adapters/Auth/index.js
View File

@@ -16,6 +16,7 @@ const vkontakte = require('./vkontakte');
const qq = require('./qq');
const wechat = require('./wechat');
const weibo = require('./weibo');
const oauth2 = require('./oauth2');
const anonymous = {
validateAuthData: () => {
@@ -45,6 +46,7 @@ const providers = {
wechat,
weibo,
};
function authDataValidator(adapter, appIds, options) {
return function(authData) {
return adapter.validateAuthData(authData, options).then(() => {
@@ -57,14 +59,21 @@ function authDataValidator(adapter, appIds, options) {
}
function loadAuthAdapter(provider, authOptions) {
const defaultAdapter = providers[provider];
const adapter = Object.assign({}, defaultAdapter);
let defaultAdapter = providers[provider];
const providerOptions = authOptions[provider];
if (
providerOptions &&
providerOptions.hasOwnProperty('oauth2') &&
providerOptions['oauth2'] === true
) {
defaultAdapter = oauth2;
}
if (!defaultAdapter && !providerOptions) {
return;
}
const adapter = Object.assign({}, defaultAdapter);
const appIds = providerOptions ? providerOptions.appIds : undefined;
// Try the configuration methods
@@ -83,6 +92,10 @@ function loadAuthAdapter(provider, authOptions) {
}
}
// TODO: create a new module from validateAdapter() in
// src/Controllers/AdaptableController.js so we can use it here for adapter
// validation based on the src/Adapters/Auth/AuthAdapter.js expected class
// signature.
if (!adapter.validateAuthData || !adapter.validateAppId) {
return;
}